linux-kernel - w1_therm_read_bin: suspicious usage of flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070614172439.GA2468@tv-sign.ru>
Date:	Thu, 14 Jun 2007 21:24:39 +0400
From:	Oleg Nesterov <oleg@...sign.ru>
To:	Evgeniy Polyakov <johnpol@....mipt.ru>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Roland McGrath <roland@...hat.com>,
	linux-kernel@...r.kernel.org
Subject: w1_therm_read_bin: suspicious usage of flush_signals()

drivers/w1/slaves/w1_therm.c:w1_therm_read_bin()

	while (tm) {
		tm = msleep_interruptible(tm);
		if (signal_pending(current))
			flush_signals(current);
	}

current is user-space task, yes?

this looks just wrong, could you please explain?

Oleg.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/