linux-kernel - Re: w1_therm_read_bin: suspicious usage of flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070615042856.GA22786@2ka.mipt.ru>
Date:	Fri, 15 Jun 2007 08:28:57 +0400
From:	Evgeniy Polyakov <johnpol@....mipt.ru>
To:	Oleg Nesterov <oleg@...sign.ru>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Roland McGrath <roland@...hat.com>,
	linux-kernel@...r.kernel.org
Subject: Re: w1_therm_read_bin: suspicious usage of flush_signals()

On Thu, Jun 14, 2007 at 09:24:39PM +0400, Oleg Nesterov (oleg@...sign.ru) wrote:
> drivers/w1/slaves/w1_therm.c:w1_therm_read_bin()
> 
> 	while (tm) {
> 		tm = msleep_interruptible(tm);
> 		if (signal_pending(current))
> 			flush_signals(current);
> 	}
> 
> current is user-space task, yes?
> 
> this looks just wrong, could you please explain?

Hi Oleg.

Well, it can be uninterruptible sleep, but why?
It is not allowed to return to userspace until transaction is completed,
so having uninterruptible sleep will result in exactly same lost of
signals.

> Oleg.

-- 
	Evgeniy Polyakov
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/