linux-kernel - Re: [PATCH 2/2] readahead: sanify file_ra

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1181882288.6237.205.camel@localhost.localdomain>
Date:	Fri, 15 Jun 2007 14:38:07 +1000
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Andrew Morton <akpm@...l.org>
Cc:	linux-kernel@...r.kernel.org, Fengguang Wu <wfg@...l.ustc.edu.cn>
Subject: Re: [PATCH 2/2] readahead: sanify file_ra_state names

On Thu, 2007-06-14 at 14:21 +0800, Fengguang Wu wrote:
> plain text document attachment (readahead-rename.patch)
> Rename some file_ra_state variables and remove some accessors.
> 
> It results in much simpler code.
> Kudos to Rusty!
> 
> Signed-off-by: Fengguang Wu <wfg@...l.ustc.edu.cn>

Needless to say, I'm now very satisfied with the new readahead code.  

That's not to say there won't be corner cases where the old code did
better, but given the replacement's simplicity and Fengguang's positive
benchmark results I really like it.

Thanks for Fengguang for coding and pushing this!
Rusty.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/