linux-kernel - Re: [PATCH 2.6.21] cramfs: add cramfs Linear XIP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <467299F5.3070704@de.ibm.com>
Date:	Fri, 15 Jun 2007 15:53:57 +0200
From:	Carsten Otte <cotte@...ibm.com>
To:	Nick Piggin <nickpiggin@...oo.com.au>
CC:	carsteno@...ibm.com, Andrew Morton <akpm@...ux-foundation.org>,
	richard.griffiths@...driver.com,
	Richard Griffiths <res07ml0@...izon.net>,
	Linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2.6.21] cramfs: add cramfs Linear XIP

Nick Piggin wrote:
> Carsten Otte wrote:
>> The current xip stack relies on having struct page behind the memory 
>> segment. This causes few impact on memory management, but occupies 
>> some more memory. The cramfs patch chose to modify copy on write in 
>> order to deal with vmas that don't have struct page behind.
>> So far, Hugh and Linus have shown strong opposition against copy on 
>> write with no struct page behind. If this implementation is acceptable 
>> to the them, it seems preferable to me over wasting memory. The xip 
>> stack should be modified to use this vma flag in that case.
> 
> I would rather not :P
> 
> We can copy on write without a struct page behind the source today, no?
> What is insufficient for the XIP code with the current COW?

I've looked at the -mm version of mm/memory.c today, with intend to 
try out VM_PFNMAP for our xip mappings and replace nopage() with fault().
The thing is, I believe it does'nt work for us:
  * The way we recognize those mappings is through the rules set up
  * by "remap_pfn_range()": the vma will have the VM_PFNMAP bit set,
  * and the vm_pgoff will point to the first PFN mapped: thus every
  * page that is a raw mapping will always honor the rule
  *
  *      pfn_of_page == vma->vm_pgoff + ((addr - vma->vm_start) >> 
PAGE_SHIFT)

This is, as far as I can tell, not true for our xip mappings. Ext2 may 
spread the physical pages behind a given file all over its media. That 
means, that the pfns of the pages that form a vma may be more or less 
random rather than contiguous. The common memory management code 
cannot tell whether or not a given page has been COW'ed.
Did I miss something?

so long,
Carsten
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/