linux-kernel - Re: [PATCH] NFS: Make NFS root work again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1182012450.26143.8.camel@heimdal.trondhjem.org>
Date:	Sat, 16 Jun 2007 12:47:30 -0400
From:	Trond Myklebust <trond.myklebust@....uio.no>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	David Howells <dhowells@...hat.com>, torvalds@...ux-foundation.org,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] NFS: Make NFS root work again

On Sat, 2007-06-16 at 09:15 -0700, Andrew Morton wrote:
> On Thu, 07 Jun 2007 17:40:03 +0100 David Howells <dhowells@...hat.com> wrote:
> 
> > Make NFS root work by creating a "/root" directory to satisfy the mount,
> > otherwise the path lookup for the mount fails with ENOENT.
> > 
> > Signed-off-by: David Howells <dhowells@...hat.com>
> > ---
> > 
> >  init/do_mounts.c |    5 ++++-
> >  1 files changed, 4 insertions(+), 1 deletions(-)
> > 
> > diff --git a/init/do_mounts.c b/init/do_mounts.c
> > index 46fe407..967b852 100644
> > --- a/init/do_mounts.c
> > +++ b/init/do_mounts.c
> > @@ -270,7 +270,10 @@ static void __init get_fs_names(char *page)
> >  
> >  static int __init do_mount_root(char *name, char *fs, int flags, void *data)
> >  {
> > -	int err = sys_mount(name, "/root", fs, flags, data);
> > +	int err;
> > +
> > +	sys_mkdir("/root", 0755);
> > +	err = sys_mount(name, "/root", fs, flags, data);
> >  	if (err)
> >  		return err;
> 
> Am still awaiting a proper description of this patch, please.
> 
> What is not working, and how does this patch fix it?
> 
> I am unaware of any open bug reports against NFS root.

I'm confused too. We never used to require that the kernel create a
special /root directory. What changed, and when?

Trond

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/