linux-kernel - RE: [PATCH 1/5] Add the explanation and sample of RapidIO DTS sector to the document of booting-without-of.txt file.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 18 Jun 2007 11:27:59 +0800
From:	"Zhang Wei-r63237" <Wei.Zhang@...escale.com>
To:	"Segher Boessenkool" <segher@...nel.crashing.org>,
	"Kumar Gala" <galak@...nel.crashing.org>
Cc:	<mporter@...nel.crashing.org>, <linux-kernel@...r.kernel.org>,
	<linuxppc-dev@...abs.org>, <paulus@...ba.org>
Subject: RE: [PATCH 1/5] Add the explanation and sample of RapidIO DTS sector to the document of booting-without-of.txt file.

Hi, Kumar and Segher, 

>
> > "..8641.." "..8641d.." "..8548.." "..8548e.." "..8543.." 
> "..8543e.." 
> > "..8572.." "..8572e.." "..8567.." "..8567e.." "..8568.." "..8568e.."
> 
> You don't need to mention _all_ compatible devices in
> the "compatible" property, only the few that matter;
> typically the oldest one, and sometimes some intermediate
> device that has extra features over the original one.
> 

The oldest one is difficult to find out sometime. Can we only set the
self name in dts, such as "fsl, rapidio-8641", and add this 'compatible'
property to the driver ids arrays? Such as:

static struct of_device_id of_rio_rpn_ids[] = {
	{ .compatible = "fsl, rapidio-8540",},
	{ .compatible = "fsl, rapidio-8560",},
	{ .compatible = "fsl, rapidio-8641",},
	{ .compatible = "fsl, rapidio-8548",},
	{},
};

How about that?

> It isn't useful to add "compatible" entries that no OS
> probes for.
> 
> >> Concrete names are good.
> >
> > While I agree concrete names are good, we put these 'blocks' in so 
> > many devices that using the device to match on is pointless.
> 
> You *definitely* should put the device name for _this_
> device in there, in case it needs some special workaround.
> 
> > I'm all for making up a name like 'Grande', 'Del', 
> 'Janeiro'.  This is 
> > effective what we did with gianfar.  The name gets picked up pretty 
> > quickly by people.
> 
> That can be used as the "base" name, yes.
> 

Do you have the name list? I can change my codes according them.

How about 'Mercurary', 'Venus', 'Earth', 'Mars', 'Saturn', 'Jupiter',
'Uranus', 'Neptune',
Or 'Aries', 'Taurus', 'Gemini', 'Cancer', 'Leo', 'Virgo', 'Libra',
'Scorpius', 'Sagittarius', 'Capricornus', 'Aquarius', 'Pisces' ?

Thanks!
Wei.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/