| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20070620183632.GG24544@erda.amd.com> Date: Wed, 20 Jun 2007 20:36:32 +0200 From: "Robert Richter" <robert.richter@....com> To: "David Rientjes" <rientjes@...gle.com> cc: "Stephane Eranian" <eranian@....hp.com>, "Andi Kleen" <andi@...stfloor.org>, linux-kernel@...r.kernel.org Subject: Re: [patch 4/8] 2.6.22-rc3 perfmon2 : IBS implementation for AMD64 David, > Please don't include mixed cases of hex digits. This entire file has all > hex digits in lowercase type, so please conform to that. I fixed this in the 2nd version of the patch. > > +#define K8_MTRRFIXRANGE_DRAM_ENABLE 0x00040000 /* MtrrFixDramEn bit */ > > +#define K8_MTRRFIXRANGE_DRAM_MODIFY 0x00080000 /* MtrrFixDramModEn bit */ > > +#define K8_MTRR_RDMEM_WRMEM_MASK 0x18181818 /* Mask: RdMem|WrMem */ > > Masks like K8_MTRR_RDMEM_WRMEM_MASK are prone to bugs when the values they > are testing change and somebody forgets to update the mask. Can you make > K8_MTRR_RDMEM_WRMEM_MASK defined to be the result of another preprocessor > macro expression? Or, even better, get rid of it completely and modify > set_fixed_range()? This is existing code, won't change that. Thanks, -Robert -- AMD Saxony, Dresden, Germany Operating System Research Center email: robert.richter@....com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists