linux-kernel - Re: [PATCH] sns: add syscall to check signed state of a process [4/4]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <961aa3350706210934m11e7f0cq96f384056878cb43@mail.gmail.com>
Date:	Fri, 22 Jun 2007 01:34:06 +0900
From:	"Akinobu Mita" <akinobu.mita@...il.com>
To:	"Alexander Wuerstlein" <arw@....name>
Cc:	linux-kernel@...r.kernel.org,
	"Johannes Schlumberger" <spjsschl@...d.informatik.uni-erlangen.de>
Subject: Re: [PATCH] sns: add syscall to check signed state of a process [4/4]

2007/6/22, Alexander Wuerstlein <arw@....name>:

> +asmlinkage int sys_sns_is_trusted(pid_t p)
> +{
> +       struct task_struct *t;
> +       rcu_read_lock();
> +       t = find_task_by_pid(p);
> +       if (IS_ERR(t)) {

Shouldn't it be:
if (!t) {
        ...
?

find_task_by_pid() returns NULL on failure.

> +               rcu_read_unlock();
> +               return -EINVAL;
> +       }
> +       p = t->sns_valid_sig; /*locking needed*/
> +       rcu_read_unlock();
> +       return p;
> +}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/