linux-kernel - Re: [RFC PATCH 0/6] Convert all tasklets to workqueues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070622064159.b762cb13.akpm@linux-foundation.org>
Date:	Fri, 22 Jun 2007 06:41:59 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	rostedt@...dmis.org, hch@...radead.org,
	linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org,
	tglx@...utronix.de, johnstul@...ibm.com, oleg@...sign.ru,
	paulmck@...ux.vnet.ibm.com, dipankar@...ibm.com,
	davem@...emloft.net, kuznet@....inr.ac.ru
Subject: Re: [RFC PATCH 0/6] Convert all tasklets to workqueues

> On Fri, 22 Jun 2007 15:26:22 +0200 Ingo Molnar <mingo@...e.hu> wrote:
> 
> * Andrew Morton <akpm@...ux-foundation.org> wrote:
> 
> > I do think that would be a better approach.  Apart from the 
> > cleanliness issue, the driver-by-driver conversion would make it much 
> > easier to hunt down any regresions or various funnineses.
> 
> there are 120 tasklet_init()s in the tree and 224 tasklet_schedule()s. 

couple of hours?

> Pushing it into thread context should work just fine (Steve's patchset 
> certainly works on my testbox), as even today we can execute softirqs 
> (and hence tasklets) in ksoftirqd. In fact, -rt has been executing 
> tasklets in task context for over 2.5 years meanwhile. Do we really want 
> to upset the whole API? Realistically it just wont ever be removed, like 
> the BKL.

We can remove it.  It might need to remain deprecated for a year, but we
shouldn't plan on leaving the old interface hanging around for ever.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/