linux-kernel - Re: [PATCH] serial: Clear proper MPSC interrupt cause bits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070623095144.0ec7e8c6.akpm@linux-foundation.org>
Date:	Sat, 23 Jun 2007 09:51:44 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	"Mark A. Greer" <mgreer@...sta.com>
Cc:	linux-kernel@...r.kernel.org, jaylubo@...orola.com
Subject: Re: [PATCH] serial: Clear proper MPSC interrupt cause bits

> On Thu, 21 Jun 2007 19:32:08 -0700 "Mark A. Greer" <mgreer@...sta.com> wrote:
> From: Jay Lubomirski <jaylubo@...orola.com>
> 
> Don't clobber the interrupt cause bits for both MPSC controllers when
> clearing the interrupt for one of them.  Just clear the one that is
> supposed to be cleared.
> 
> Signed-off-by: Jay Lubomirski <jaylubo@...orola.com>
> Acked-by: Mark A. Greer <mgreer@...sta.com>
> ---
>  drivers/serial/mpsc.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/serial/mpsc.c b/drivers/serial/mpsc.c
> index d09f209..00924fe 100644
> --- a/drivers/serial/mpsc.c
> +++ b/drivers/serial/mpsc.c
> @@ -503,7 +503,8 @@ mpsc_sdma_intr_ack(struct mpsc_port_info *pi)
>  
>  	if (pi->mirror_regs)
>  		pi->shared_regs->SDMA_INTR_CAUSE_m = 0;
> -	writel(0, pi->shared_regs->sdma_intr_base + SDMA_INTR_CAUSE);
> +	writeb(0x00, pi->shared_regs->sdma_intr_base + SDMA_INTR_CAUSE +
> +	       pi->port.line);
>  	return;
>  }

In my naive little mpscless bubbleworld, I am believing that this is a
pretty important fix, and that people in an mpscful world might want it in
2.6.22.  And even in 2.6.21.x.

But alas, that's just a guess, which was forced upon me by the lack of
suitable information in your changelog.

So please, tell us what are the real-world consequences of your patch (or
the lack of it), thanks.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/