linux-kernel - Re: [PATCH 1/2] [RESEND] PCI: read revision ID by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070625100109.35b4c327@the-village.bc.nu>
Date:	Mon, 25 Jun 2007 10:01:09 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Auke Kok <auke-jan.h.kok@...el.com>
Cc:	gregkh@...e.de, linux-pci@...ey.karlin.mff.cuni.cz,
	linux-kernel@...r.kernel.org, grundler@...isc-linux.org,
	davem@...emloft.net, davej@...hat.com
Subject: Re: [PATCH 1/2] [RESEND] PCI: read revision ID by default

On Sun, 24 Jun 2007 20:19:18 -0700
Auke Kok <auke-jan.h.kok@...el.com> wrote:

> Currently there are 97 occurrences where drivers need the pci
> revision ID. We can do this once for all devices. Even the pci
> subsystem needs the revision several times for quirks. The extra
> u8 member pads out nicely in the pci_dev struct.
> 
> Signed-off-by: Auke Kok <auke-jan.h.kok@...el.com>

Seems worth caching yes. Care needed changing the other uses however
that the revision isn't changeable on the hardware in some magic fashion.

Acked-by: Alan Cox <alan@...hat.com>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/