linux-kernel - Re: [PATCH 2/2] [RESEND] PCI: Change all drivers to use pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070625100447.1b3ae35e@the-village.bc.nu>
Date:	Mon, 25 Jun 2007 10:04:47 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Auke Kok <auke-jan.h.kok@...el.com>
Cc:	gregkh@...e.de, linux-pci@...ey.karlin.mff.cuni.cz,
	linux-kernel@...r.kernel.org, grundler@...isc-linux.org,
	davem@...emloft.net, davej@...hat.com
Subject: Re: [PATCH 2/2] [RESEND] PCI: Change all drivers to use
 pci_device->revision

On Sun, 24 Jun 2007 20:19:29 -0700
Auke Kok <auke-jan.h.kok@...el.com> wrote:

> Instead of all drivers reading pci config space to get the revision
> ID, they can now use the pci_device->revision member.
> 
> This exposes some issues where drivers where reading a word or a dword
> for the revision number, and adding useless error-handling around the
> read. Some drivers even just read it for no purpose of all.
> 
> In devices where the revision ID is being copied over and used in what
> appears to be the equivalent of hotpath, I have left the copy code
> and the cached copy as not to influence the driver's performance.
> 
> Compile tested with make all{yes,mod}config on x86_64 and i386.

Ack the drivers/ata part but please split this up per subsystem and send
the chunks to the subsystem maintainers.

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/