linux-kernel - Re: [patch, 2.6.22-rc6] fix nmi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <467FB9C1.5090001@goop.org>
Date:	Mon, 25 Jun 2007 08:49:05 -0400
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	Björn Steinbrink <B.Steinbrink@....de>,
	Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Andi Kleen <andi@...stfloor.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Jeremy Fitzhardinge <jeremy@...p.org>,
	Rusty Russell <rusty@...tcorp.com.au>
Subject: Re: [patch, 2.6.22-rc6] fix nmi_watchdog=2 bootup hang

Björn Steinbrink wrote:
> On 2007.06.25 10:26:52 +0200, Ingo Molnar wrote:
>   
>> * Ingo Molnar <mingo@...e.hu> wrote:
>>
>>     
>>> the winner is ...
>>>
>>>  f8822f42019eceed19cc6c0f985a489e17796ed8 is first bad commit
>>>  commit f8822f42019eceed19cc6c0f985a489e17796ed8
>>>  Author: Jeremy Fitzhardinge <jeremy@...p.org>
>>>  Date:   Wed May 2 19:27:14 2007 +0200
>>>
>>>     [PATCH] i386: PARAVIRT: Consistently wrap paravirt ops callsites to make them patchable
>>>       
>> and of course i'm happy to test any patch that is simpler than the 
>> brutal revert i sent.
>>     
>
> wrmsrl() looks broken, dropping the upper 32bits of the value to be
> written. Does this help?
>   

Crap.  That's embarrassing.  Does it help, because it seems likely?  
(Esp since Ingo didn't even have CONFIG_PARAVIRT enabled, so most of his 
revert would have been dead code anyway.)

    J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/