linux-kernel - Re: [PATCH v2] pcmcia: CompactFlash driver for PA Semi Electra boards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070625193909.GA26021@infradead.org>
Date:	Mon, 25 Jun 2007 20:39:09 +0100
From:	Christoph Hellwig <hch@...radead.org>
To:	Olof Johansson <olof@...om.net>
Cc:	linux-kernel@...r.kernel.org, linux-pcmcia@...ts.infradead.org,
	linuxppc-dev@...abs.org, Russell King <rmk+lkml@....linux.org.uk>,
	Christoph Hellwig <hch@...radead.org>
Subject: Re: [PATCH v2] pcmcia: CompactFlash driver for PA Semi Electra boards

On Mon, Jun 25, 2007 at 12:12:21PM -0500, Olof Johansson wrote:
> Driver for the CompactFlash slot on the PA Semi Electra eval board. It's
> a simple device sitting on localbus, with interrupts and detect/voltage
> control over GPIO.
> 
> The driver is implemented as an of_platform driver, and adds localbus
> as a bus being probed by the of_platform framework.

Looks good to me. The only odd thing is the inconsistant use of
#ifdef CONFIG_PCMCIA in setup.c.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/