linux-kernel - Re: [PATCH 1/2] rtc: add rtc-m41t80 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070626.141536.126143027.nemoto@toshiba-tops.co.jp>
Date:	Tue, 26 Jun 2007 14:15:36 +0900 (JST)
From:	Atsushi Nemoto <anemo@....ocn.ne.jp>
To:	akpm@...ux-foundation.org
Cc:	a.zummo@...ertech.it, linux-kernel@...r.kernel.org,
	rtc-linux@...glegroups.com, ab@...able.de, mgreer@...sta.com,
	khali@...ux-fr.org, david-b@...bell.net
Subject: Re: [PATCH 1/2] rtc: add rtc-m41t80 driver

On Mon, 25 Jun 2007 21:46:20 -0700, Andrew Morton <akpm@...ux-foundation.org> wrote:
> > +	const static struct m41t80_chip_info *chip;
> 
> It's a bit weird that `chip' has static storage class here.  Was that
> deliberate?

Oh the variable should not be static!
I will send updated patch.

BTW, I reveived following mails:

Subject: - rtc-watchdog-support-for-rtc-m41t80-driver-take-2.patch removed from -mm tree
Subject: - rtc-add-rtc-m41t80-driver-take-2.patch removed from -mm tree
Subject: + rtc-add-rtc-m41t80-driver.patch added to -mm tree
Subject: + rtc-watchdog-support-for-rtc-m41t80-driver.patch added to -mm tree

Are you going back to "take 1" patches?  Why?

---
Atsushi Nemoto
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/