[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20070625222142.e9215829.akpm@linux-foundation.org>
Date: Mon, 25 Jun 2007 22:21:42 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Atsushi Nemoto <anemo@....ocn.ne.jp>
Cc: a.zummo@...ertech.it, linux-kernel@...r.kernel.org,
rtc-linux@...glegroups.com, ab@...able.de, mgreer@...sta.com,
khali@...ux-fr.org, david-b@...bell.net
Subject: Re: [PATCH 1/2] rtc: add rtc-m41t80 driver
On Tue, 26 Jun 2007 14:15:36 +0900 (JST) Atsushi Nemoto <anemo@....ocn.ne.jp> wrote:
> On Mon, 25 Jun 2007 21:46:20 -0700, Andrew Morton <akpm@...ux-foundation.org> wrote:
> > > + const static struct m41t80_chip_info *chip;
> >
> > It's a bit weird that `chip' has static storage class here. Was that
> > deliberate?
>
> Oh the variable should not be static!
> I will send updated patch.
I'll fix it up.
> BTW, I reveived following mails:
>
> Subject: - rtc-watchdog-support-for-rtc-m41t80-driver-take-2.patch removed from -mm tree
> Subject: - rtc-add-rtc-m41t80-driver-take-2.patch removed from -mm tree
> Subject: + rtc-add-rtc-m41t80-driver.patch added to -mm tree
> Subject: + rtc-watchdog-support-for-rtc-m41t80-driver.patch added to -mm tree
>
> Are you going back to "take 1" patches? Why?
Stupidity, apparently. Will restore the take2 patches.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists