linux-kernel - Re: [linux-usb-devel] [PATCH] PXA27x UDC driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4684CAF7.9050201@gmail.com>
Date:	Fri, 29 Jun 2007 13:03:51 +0400
From:	Dmitry Krivoschekov <dmitry.krivoschekov@...il.com>
To:	David Brownell <david-b@...bell.net>
CC:	Rodolfo Giometti <giometti@...eenne.com>,
	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Li Yang-r58472 <LeoLi@...escale.com>,
	linux-usb-devel@...ts.sourceforge.net,
	linux-arm-kernel@...ts.arm.linux.org.uk
Subject: Re: [linux-usb-devel] [PATCH] PXA27x UDC driver.

David Brownell wrote:
> On Thursday 28 June 2007, Rodolfo Giometti wrote:
>
>> As suggest by Leo let me propose to you my new patch for PXA27x UDC
>> support.
>>
>> Please, let me know what I have to do for kernel inclusion. :)
>
> Let's start with *JUST* a driver, not trying to update everything
> else in the USB Gadget stack so that it looks like it's designed
> specifically to handle all of Intel's design botches related to
> endpoint config ... and work worse for essentially everything else.
>
> (Unlike pretty much every other vendor, Intel wanted hardware config
> management. It was unusably buggy in pxa21x/25x/26x, and not much
> better in pxa27x.)
>
>
> So in technical terms, and to repeat what I've said before: just
> configure it to act more like a PXA 25x chip (no altsettings) and
> get it so it passes all the tests [1], modulo errata which have no
> workarounds

Other options are:

    1. pre-program endpoints so the setting covers all gadget
       configurations, it seems it's feasible. The only appreciable
       change is, CDC Ethernet config number should be 3 instead of 1.
       It should not break anything.

    2. Implement a FAKE call of GET_CONFIGURATION command so upon
       gadget binding you can issue the command and program endpoints
       according to the received gadget configuration.

Also, considering that PXA3XX processors include PXA27x-compatible
USB device controller it makes sense to develop a driver that
will support both processor families. Hopefully PXA3XX arch
support will be merged some day (the arch support has been already
submitted here, but I don't know about its current status).


Regards,
Dmitry

> ... then submit that. No epautoconfig updates, no
> patches to every gadget driver to cope with updated autoconfig.
>
> Once there's a basic working no-frills version merged, then we can
> talk about whether things in the rest of the stack should change
> to accomodate the bizarre concepts of this controller.
>
> - Dave
>
>
> [1] http://www.linux-usb.org/usbtest/
>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/