linux-kernel - Re: [linux-usb-devel] [PATCH] PXA27x UDC driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 29 Jun 2007 13:33:24 +0400
From:	Dmitry Krivoschekov <dmitry.krivoschekov@...il.com>
To:	Rodolfo Giometti <giometti@...eenne.com>
CC:	David Brownell <david-b@...bell.net>, linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Li Yang-r58472 <LeoLi@...escale.com>,
	linux-usb-devel@...ts.sourceforge.net,
	linux-arm-kernel@...ts.arm.linux.org.uk
Subject: Re: [linux-usb-devel] [PATCH] PXA27x UDC driver.

Rodolfo Giometti wrote:
> On Thu, Jun 28, 2007 at 02:53:22PM -0700, David Brownell wrote:
>> Let's start with *JUST* a driver, not trying to update everything
>> else in the USB Gadget stack so that it looks like it's designed
>> specifically to handle all of Intel's design botches related to
>> endpoint config ... and work worse for essentially everything else.
>>
>> (Unlike pretty much every other vendor, Intel wanted hardware config
>> management.  It was unusably buggy in pxa21x/25x/26x, and not much
>> better in pxa27x.)
>>
>>
>> So in technical terms, and to repeat what I've said before:  just
>> configure it to act more like a PXA 25x chip (no altsettings) and
>> get it so it passes all the tests [1], modulo errata which have no
>> workarounds ... then submit that.  No epautoconfig updates, no
>> patches to every gadget driver to cope with updated autoconfig.
>
> This looks interesting... as you alredy told this driver derives from
> an older one, I just maintained it till now.
>
> If I well understand I should remove usb_ep_autoconfig() and program
> into the controller only one (the default) configuration. Is that
> right?
You should leave the usb_ep_autoconfig() as is, i.e. do not introduce
any new parameters to it.
>
> Currently I tested the driver only with ether gadget, 
Why have you submitted the limited driver then? You should test
the driver with all gadgets. Also, please report  how it works
in DMA and PIO modes. And what transfer rate the driver achives
in both modes.
> but if I do as
> above, should I get the driver working with all gadgets automagically?
Probably no, but technically there is no reason to not support
all gadgets.

BTW, I suggest that you wait until PXA3XX arch support will be
merged into mainline kernel, then, pxa27x_udc-compatible driver
will probably be submitted too. Taking into account that
pxa27_udc have not been merged for years, I think extra
2-3 month is ok.


Regards,
Dmitry

> :)
>
> Thanks a lot,
>
> Rodolfo
>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/