[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20070629181205.GA16724@uranus.ravnborg.org>
Date: Fri, 29 Jun 2007 20:12:05 +0200
From: Sam Ravnborg <sam@...nborg.org>
To: Jeremy Fitzhardinge <jeremy@...p.org>
Cc: Roman Zippel <zippel@...ux-m68k.org>,
"Eric W. Biederman" <ebiederm@...ssion.com>,
lkml <linux-kernel@...r.kernel.org>,
Andrew Morton <akpm@...ux-foundation.org>,
Linux Arch <linux-arch@...r.kernel.org>,
Al Viro <viro@....linux.org.uk>
Subject: Re: [PATCH] cross-architecture ELF clean up
On Fri, Jun 29, 2007 at 10:53:39AM -0400, Jeremy Fitzhardinge wrote:
> Roman Zippel wrote:
> >The problem I have is that you want to separate _all_ constants, which
> >doesn't really make sense to me, because many of them are useless without
> >the correspending structures.
> >
>
> It seems cleanest to just put all the constants in one place rather than
> scatter them around based on how they happen to be used.
Grouping related things together is always a good approach. But the right
factor should be used for the grouping. For the ELF file is would from a usage
perspective be natural to have constants close to the definition that
they are used to describe. Having constants grouped with other constants just
_because_ they are constants does not cut here.
Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists