lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <20070629182651.GA12811@elte.hu>
Date:	Fri, 29 Jun 2007 20:26:51 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Jeff Mahoney <jeffm@...e.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: [patch] saa7134 fix

the fix in this commit:

| commit 58e78475ec706f93e0cc049449ffd11fbfdadb3e
| Author: Jeff Mahoney <jeffm@...e.com>
| Date:   Wed Jun 27 14:09:58 2007 -0700
|
|    saa7134: fix thread shutdown handling
|
|    This patch changes the test for the thread pid from >= 0 to > 0.

might be incomplete - there's another place where this driver has a
pid >= 0 check. Should this be 'pid > 0' too?

Signed-off-by: Ingo Molnar <mingo@...e.hu>
---
 drivers/media/video/saa7134/saa7134-tvaudio.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: v/drivers/media/video/saa7134/saa7134-tvaudio.c
===================================================================
--- v.orig/drivers/media/video/saa7134/saa7134-tvaudio.c
+++ v/drivers/media/video/saa7134/saa7134-tvaudio.c
@@ -1020,7 +1020,7 @@ int saa7134_tvaudio_do_scan(struct saa71
 		dprintk("sound IF not in use, skipping scan\n");
 		dev->automute = 0;
 		saa7134_tvaudio_setmute(dev);
-	} else if (dev->thread.pid >= 0) {
+	} else if (dev->thread.pid > 0) {
 		dev->thread.mode = UNSET;
 		dev->thread.scan2++;
 		wake_up_interruptible(&dev->thread.wq);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ