linux-kernel - Re: PATCH: Fix SVM MSR indexes for 32bit kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <46854F2D.9080604@zytor.com>
Date:	Fri, 29 Jun 2007 14:27:57 -0400
From:	"H. Peter Anvin" <hpa@...or.com>
To:	"H. J. Lu" <hjl@...on.org>
CC:	joerg.roedel@....com, linux kernel <linux-kernel@...r.kernel.org>
Subject: Re: PATCH: Fix SVM MSR indexes for 32bit kernel

H. J. Lu wrote:
> }
> [hjl@...-5 tmp]$ gcc -m32 -S foo.c
> foo.c: In function â_disabledâfoo.c:7: error: impossible register
> constraint in âmâoo.c:12: confused by earlier errors, bailing out
> [hjl@...-5 tmp]$
> 
> on 32bit. This patch removes the ULL suffix in SVM MSR indexes.
> 
> 
> H.J.
> --- linux-2.6.21.i686/drivers/kvm/svm.h.msr	2007-06-28 22:42:12.000000000 -0700
> +++ linux-2.6.21.i686/drivers/kvm/svm.h	2007-06-29 08:03:09.000000000 -0700
> @@ -175,8 +175,8 @@ struct __attribute__ ((__packed__)) vmcb
>  #define SVM_CPUID_FUNC 0x8000000a
>  
>  #define MSR_EFER_SVME_MASK (1ULL << 12)
> -#define MSR_VM_CR       0xc0010114ULL
> -#define MSR_VM_HSAVE_PA 0xc0010117ULL
> +#define MSR_VM_CR       0xc0010114
> +#define MSR_VM_HSAVE_PA 0xc0010117
>  

Please take the MSR indicies out of this file and move them to 
include/asm-i386/msr-index.h.

	-hpa

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/