lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 29 Jun 2007 01:31:18 -0400 From: Jeremy Fitzhardinge <jeremy@...p.org> To: Paul Mackerras <paulus@...ba.org> CC: "Eric W. Biederman" <ebiederm@...ssion.com>, lkml <linux-kernel@...r.kernel.org>, Andrew Morton <akpm@...ux-foundation.org>, Linux Arch <linux-arch@...r.kernel.org>, Richard Henderson <rth@...ddle.net>, Ian Molton <spyro@....com>, Russell King <rmk@....linux.org.uk>, Haavard Skinnemoen <hskinnemoen@...el.com>, Aubrey Li <aubrey.li@...log.com>, Mikael Starvik <starvik@...s.com>, David Howells <dhowells@...hat.com>, Yoshinori Sato <ysato@...rs.sourceforge.jp>, Andi Kleen <ak@...e.de>, Tony Luck <tony.luck@...el.com>, Geert Uytterhoeven <geert@...ux-m68k.org>, Ralf Baechle <ralf@...ux-mips.org>, Matthew Wilcox <matthew@....cx>, Martin Schwidefsky <schwidefsky@...ibm.com>, Paul Mundt <lethal@...ux-sh.org>, "David S. Miller" <davem@...emloft.net>, Miles Bader <uclinux-v850@....nec.co.jp>, Chris Zankel <chris@...kel.net> Subject: Re: [PATCH] cross-architecture ELF clean up Paul Mackerras wrote: >> =================================================================== >> --- a/arch/powerpc/platforms/cell/io-workarounds.c >> +++ b/arch/powerpc/platforms/cell/io-workarounds.c >> @@ -9,6 +9,7 @@ >> #undef DEBUG >> >> #include <linux/kernel.h> >> +#include <linux/sched.h> >> > > Why is this needed? You've added #include <linux/sched.h> to 7 files > without explanation - and I can't see that you have removed a > corresponding #include from any header, have you? > asm-powerpc/elf.h included sched.h, and it in turn was being included by something else. With the cleanups in this patch, asm-powerpc/elf.h is no longer being included, so io-workarounds.c needs kernel/sched.h for a declaration of init_mm. Similarly with the others; they all failed to compile without linux/sched.h. J - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists