linux-kernel - Re: [v4l-dvb-maintainer] [PATCH] se401: fix "&& 0x" typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1183387602.5456.106.camel@gaivota>
Date:	Mon, 02 Jul 2007 11:46:42 -0300
From:	Mauro Carvalho Chehab <mchehab@...radead.org>
To:	Alexey Dobriyan <adobriyan@...ru>
Cc:	pe1rxq@...at.org, v4l-dvb-maintainer@...uxtv.org,
	linux-kernel@...r.kernel.org, devel@...nvz.org
Subject: Re: [v4l-dvb-maintainer] [PATCH] se401: fix "&& 0x" typo

Em Seg, 2007-07-02 às 15:04 +0400, Alexey Dobriyan escreveu:
> Code there survived trivial regexp made earlier, but after bulk preprocessing
> was done...
> 
> ===>	if (!cp[2] && 0x40) {	<===
> 		printk("<3>" "%s: " "Bayer format not supported!" ...
> 		return 1;
> 	}
> 
> 
> NOTE: to me, check or error message should be reverted, but I know nothing
> about this driver.

Your patch looks to be coherent. However, I suspect that this will break
the driver. There are some functions at the driver for decoding Bayer
format. Without your patch, the if condition will never occur. So, Bayer
decoding will work. 

IMO, the better is to add an #if 0 at the test.

-- 
Cheers,
Mauro

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/