linux-kernel - [PATCH] se401: fix "&& 0x" typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 2 Jul 2007 15:04:53 +0400
From:	Alexey Dobriyan <adobriyan@...ru>
To:	pe1rxq@...at.org, v4l-dvb-maintainer@...uxtv.org
Cc:	linux-kernel@...r.kernel.org, devel@...nvz.org
Subject: [PATCH] se401: fix "&& 0x" typo

Code there survived trivial regexp made earlier, but after bulk preprocessing
was done...

===>	if (!cp[2] && 0x40) {	<===
		printk("<3>" "%s: " "Bayer format not supported!" ...
		return 1;
	}


NOTE: to me, check or error message should be reverted, but I know nothing
about this driver.

Signed-off-by: Alexey Dobriyan <adobriyan@...ru>
---

 drivers/media/video/se401.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/media/video/se401.c
+++ b/drivers/media/video/se401.c
@@ -1280,7 +1280,7 @@ static int se401_init(struct usb_se401 *se401, int button)
 	rc=se401_sndctrl(0, se401, SE401_REQ_GET_HEIGHT, 0, cp, sizeof(cp));
 	se401->cheight=cp[0]+cp[1]*256;
 
-	if (!cp[2] && SE401_FORMAT_BAYER) {
+	if (!(cp[2] & SE401_FORMAT_BAYER)) {
 		err("Bayer format not supported!");
 		return 1;
 	}

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/