| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <a781481a0707011921j518d29b8q77438921a41504c5@mail.gmail.com> Date: Mon, 2 Jul 2007 07:51:37 +0530 From: "Satyam Sharma" <satyam.sharma@...il.com> To: "Josef Sipek" <jsipek@....cs.sunysb.edu> Cc: "Adrian Bunk" <bunk@...sta.de>, linux-kernel@...r.kernel.org Subject: Re: [-mm patch] unionfs: make functions static Hi, [ Cc:'s trimmed ] On 7/2/07, Josef Sipek <jsipek@....cs.sunysb.edu> wrote: > On Sun, Jul 01, 2007 at 10:23:30PM +0200, Adrian Bunk wrote: > > This patch makes some needlessly global functions static. > > > ... > > --- linux-2.6.22-rc6-mm1/fs/unionfs/lookup.c.old 2007-07-01 00:05:02.000000000 +0200 > > +++ linux-2.6.22-rc6-mm1/fs/unionfs/lookup.c 2007-07-01 00:06:05.000000000 +0200 > > @@ -18,6 +18,8 @@ > > > > #include "union.h" > > > > +static int realloc_dentry_private_data(struct dentry *dentry); > > + > > /* is the filename valid == !(whiteout for a file or opaque dir marker) */ > > I forget who said it, but someone wasn't very happy with prototypes like > that in .c files. What's the prefered way - are they ok for static symbols? The preferred way is to push static functions' definitions above the callsites (caller functions) in the same file, if possible. Perhaps Adrian was in a hurry so didn't do that ... Satyam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists