linux-kernel - Re: Linux 2.6.22-rc7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070703164626.GZ22589@skl-net.de>
Date:	Tue, 3 Jul 2007 18:46:26 +0200
From:	Andre Noll <maan@...temlinux.org>
To:	Christoph Lameter <clameter@....com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...e.hu>
Subject: Re: Linux 2.6.22-rc7

On 09:31, Christoph Lameter wrote:

> > Andre, does that simple change fix it for you (move the 
> > "local_irq_enable()" to the end of early_kmem_cache_node_alloc)?
> 
> Yes that should make the lock checker happy since interrupts are disabled 
> when calling add_partial(). local_irq_enable can be called later without a 
> problem. Useless longer interrupt hold off though.

I can confirm that the message disappears if local_irq_enable() is moved
to the end of the function.

> SLUB: Make lockdep happy by not calling add_partial with interrupts 
> enabled during bootstrap
> 
> If we move the local_irq_enable() to the end of the function then
> add_partial() in early_kmem_cache_node_alloc() will be called
> with interrupts disabled like during regular operations.
> 
> Signed-off-by: Christoph Lameter <clameter@....com>

Tested-By: Andre Noll <maan@...temlinux.org>

Thanks for the quick response and the fix, Linus and Christoph.

Andre
-- 
The only person who always got his work done by Friday was Robinson Crusoe

Download attachment "signature.asc" of type "application/pgp-signature" (190 bytes)