linux-kernel - [PATCH] Libertas: Fix regression in cmd.c introduced in commit 18c96c3497aa871608d57ca5e08de3558159a6c9

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <b8e9195f0707051609v36182409mc07f030cca790a7a@mail.gmail.com>
Date:	Fri, 6 Jul 2007 01:09:34 +0200
From:	"Guillaume LECERF" <glecerf@...il.com>
To:	linux-kernel@...r.kernel.org
Subject: [PATCH] Libertas: Fix regression in cmd.c introduced in commit 18c96c3497aa871608d57ca5e08de3558159a6c9

Hi all,

While reading the last libertas commits, I discovered that this commit
introduced a regression in the libertas wireless driver, inside cmd.c
:

commit 18c96c3497aa871608d57ca5e08de3558159a6c9
[PATCH] libertas: fix WPA associations by handling ENABLE_RSN correctly

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=18c96c3497aa871608d57ca5e08de3558159a6c9

The logic behind has been totally broken, and I think this patch is
worth reviewing.

Regards,

--- a/drivers/net/wireless/libertas/cmd.c
+++ b/drivers/net/wireless/libertas/cmd.c
@@ -241,7 +241,7 @@
                if (*enable)
                        penableRSN->enable = cpu_to_le16(cmd_enable_rsn);
                else
-                       penableRSN->enable = cpu_to_le16(cmd_enable_rsn);
+                       penableRSN->enable = cpu_to_le16(cmd_disable_rsn);
        }

        lbs_deb_leave(LBS_DEB_CMD);

-- 
Guillaume LECERF
GeeXboX developer
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/