linux-kernel - Re: [PATCH] Libertas: Fix regression in cmd.c introduced in commit 18c96c3497aa871608d57ca5e08de3558159a6c9

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a781481a0707060029r3ebf237bl84e27247f0943820@mail.gmail.com>
Date:	Fri, 6 Jul 2007 12:59:28 +0530
From:	"Satyam Sharma" <satyam.sharma@...il.com>
To:	"Guillaume LECERF" <glecerf@...il.com>
Cc:	linux-kernel@...r.kernel.org, "Dan Williams" <dcbw@...hat.com>,
	"John W. Linville" <linville@...driver.com>
Subject: Re: [PATCH] Libertas: Fix regression in cmd.c introduced in commit 18c96c3497aa871608d57ca5e08de3558159a6c9

Hi Guillaume,

[ Added relevant folks to Cc: ]

On 7/6/07, Guillaume LECERF <glecerf@...il.com> wrote:
> [...]
>
> --- a/drivers/net/wireless/libertas/cmd.c
> +++ b/drivers/net/wireless/libertas/cmd.c
> @@ -241,7 +241,7 @@
>                 if (*enable)
>                         penableRSN->enable = cpu_to_le16(cmd_enable_rsn);
>                 else
> -                       penableRSN->enable = cpu_to_le16(cmd_enable_rsn);
> +                       penableRSN->enable = cpu_to_le16(cmd_disable_rsn);
>         }
>
>         lbs_deb_leave(LBS_DEB_CMD);
>

Thanks for the patch (looks reasonable to me), but:

1. No point sending a patch without a "Signed-off-by:" line.
2. Changelog (a few lines of explanation before signed-off-by) must
specify what was wrong, and why the patch is correct.
3. Always Cc: relevant maintainers or at least _somebody_ who
_will_ pick it up.
4. Gmail has done horrible things to the patch as usual, use some
other mailer or script.

And in general, please read: Documentation/SubmittingPatches
and http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt

Satyam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/