linux-kernel - Re: [PATCH] Libertas: Fix regression in cmd.c introduced in commit 18c96c3497aa871608d57ca5e08de3558159a6c9

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1183722493.15222.3.camel@xo-13-A4-25.localdomain>
Date:	Fri, 06 Jul 2007 07:48:13 -0400
From:	Dan Williams <dcbw@...hat.com>
To:	Satyam Sharma <satyam.sharma@...il.com>
Cc:	Guillaume LECERF <glecerf@...il.com>, linux-kernel@...r.kernel.org,
	"John W. Linville" <linville@...driver.com>
Subject: Re: [PATCH] Libertas: Fix regression in cmd.c introduced in commit
	18c96c3497aa871608d57ca5e08de3558159a6c9

On Fri, 2007-07-06 at 12:59 +0530, Satyam Sharma wrote:
> Hi Guillaume,
> 
> [ Added relevant folks to Cc: ]

Botched backport, head is correct.  It's worth noting that WPA didn't
work before the original commit at _all_, and after the commit it would
actually work, but you probably couldn't turn it off :)

Thanks for the catch, I'll fix and push to linville.

dan

> On 7/6/07, Guillaume LECERF <glecerf@...il.com> wrote:
> > [...]
> >
> > --- a/drivers/net/wireless/libertas/cmd.c
> > +++ b/drivers/net/wireless/libertas/cmd.c
> > @@ -241,7 +241,7 @@
> >                 if (*enable)
> >                         penableRSN->enable = cpu_to_le16(cmd_enable_rsn);
> >                 else
> > -                       penableRSN->enable = cpu_to_le16(cmd_enable_rsn);
> > +                       penableRSN->enable = cpu_to_le16(cmd_disable_rsn);
> >         }
> >
> >         lbs_deb_leave(LBS_DEB_CMD);
> >
> 
> Thanks for the patch (looks reasonable to me), but:
> 
> 1. No point sending a patch without a "Signed-off-by:" line.
> 2. Changelog (a few lines of explanation before signed-off-by) must
> specify what was wrong, and why the patch is correct.
> 3. Always Cc: relevant maintainers or at least _somebody_ who
> _will_ pick it up.
> 4. Gmail has done horrible things to the patch as usual, use some
> other mailer or script.
> 
> And in general, please read: Documentation/SubmittingPatches
> and http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt
> 
> Satyam

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/