linux-kernel - Re: [PATCH] debug workqueue flushing deadlocks with lockdep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070705084806.GB3476@elte.hu>
Date:	Thu, 5 Jul 2007 10:48:06 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Johannes Berg <johannes@...solutions.net>
Cc:	Linux Kernel list <linux-kernel@...r.kernel.org>,
	Oleg Nesterov <oleg@...sign.ru>,
	Arjan van de Ven <arjan@...radead.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Thomas Sattler <tsattler@....de>
Subject: Re: [PATCH] debug workqueue flushing deadlocks with lockdep


* Johannes Berg <johannes@...solutions.net> wrote:

> This patch adds a fake lock to each workqueue in order to debug things 
> where you have something like
> 
>   my_function() -> lock(); ...; flush_workqueue(); ...
> vs
>   run_workqueue() -> my_work() -> ...; lock(); ...
> 
> which can obviously deadlock if my_work is scheduled when my_function()
> is invoked (but hasn't locked yet.)
> 
> Signed-off-by: Johannes Berg <johannes@...solutions.net>

i'm still impressed by the elegancy of your idea :)

Acked-by: Ingo Molnar <mingo@...e.hu>

btw., small patch format comment: it would be useful (in the future) to 
send such combined patches as:

 [patch 0/2] general description
 [patch 1/2] first patch
 [patch 2/2] second patch

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/