[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20070705084538.GA3476@elte.hu>
Date: Thu, 5 Jul 2007 10:45:38 +0200
From: Ingo Molnar <mingo@...e.hu>
To: Johannes Berg <johannes@...solutions.net>
Cc: Linux Kernel list <linux-kernel@...r.kernel.org>,
Oleg Nesterov <oleg@...sign.ru>,
Arjan van de Ven <arjan@...radead.org>,
Peter Zijlstra <a.p.zijlstra@...llo.nl>,
Thomas Sattler <tsattler@....de>
Subject: Re: [PATCH] debug work struct cancel deadlocks with lockdep
* Johannes Berg <johannes@...solutions.net> wrote:
> +#ifdef CONFIG_LOCKDEP
> + /*
> + * It is permissible to free the struct work_struct
> + * from inside the function that is called from it,
> + * this we need to take into account for lockdep too.
> + * To avoid bogus "held lock freed" warnings as well
> + * as problems when looking into work->lockdep_map,
> + * make a copy and use that here.
> + */
> + struct lockdep_map lockdep_map = work->lockdep_map;
> +#endif
> + lock_acquire(&lockdep_map, 0, 0, 0, 2, _THIS_IP_);
> f(work);
> + lock_release(&lockdep_map, 1, _THIS_IP_);
neat trick :)
Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists