linux-kernel - Re: [PATCH] debug work struct cancel deadlocks with lockdep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1183625448.3818.6.camel@johannes.berg>
Date:	Thu, 05 Jul 2007 10:50:48 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Linux Kernel list <linux-kernel@...r.kernel.org>,
	Oleg Nesterov <oleg@...sign.ru>,
	Arjan van de Ven <arjan@...radead.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Thomas Sattler <tsattler@....de>
Subject: Re: [PATCH] debug work struct cancel deadlocks with lockdep

On Thu, 2007-07-05 at 10:45 +0200, Ingo Molnar wrote:

> > +#ifdef CONFIG_LOCKDEP
> > +		/*
> > +		 * It is permissible to free the struct work_struct
> > +		 * from inside the function that is called from it,
> > +		 * this we need to take into account for lockdep too.
> > +		 * To avoid bogus "held lock freed" warnings as well
> > +		 * as problems when looking into work->lockdep_map,
> > +		 * make a copy and use that here.
> > +		 */
> > +		struct lockdep_map lockdep_map = work->lockdep_map;
> > +#endif
> 
> > +		lock_acquire(&lockdep_map, 0, 0, 0, 2, _THIS_IP_);
> >  		f(work);
> > +		lock_release(&lockdep_map, 1, _THIS_IP_);
> 
> neat trick :)

Not like I had a choice ;) But since I assign .key it still works :)

Btw, do you have a tree you'll submit this through, or Oleg, or should I
send it to akpm after we sort out any further issues?

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (191 bytes)