linux-kernel - Re: [PATCH] debug work struct cancel deadlocks with lockdep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1183625889.3818.14.camel@johannes.berg>
Date:	Thu, 05 Jul 2007 10:58:08 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Linux Kernel list <linux-kernel@...r.kernel.org>,
	Oleg Nesterov <oleg@...sign.ru>,
	Arjan van de Ven <arjan@...radead.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Thomas Sattler <tsattler@....de>
Subject: Re: [PATCH] debug work struct cancel deadlocks with lockdep

On Thu, 2007-07-05 at 10:53 +0200, Ingo Molnar wrote:

> > +#ifdef CONFIG_LOCKDEP
> > +/*
> > + * HACK! This really should call lockdep_init_map() but can't
> > + * because there's no requirement to initialise work structs
> > + * at runtime. This works because subclass == 0.
> > + *
> > + * NB: because we have to copy the lockdep_map, setting .key
> > + * here is required!
> > + */
> 
> why do you consider this a hack? A static object is a static object, and 
> its own address is its key. That's what we have for like 80% of all the 
> spinlocks in the kernel. Static initialization is not as flexible as 
> dynamic initialization, but the lockdep engine handles it. Am i missing 
> something?

Well, there's nothing in lockdep that guarantees that. I'd be much more
comfortable doing that when lockdep had a STATIC_LOCKDEP_MAP_INIT()
macro that looks like my __WORK_INIT_LOCKDEP_MAP() macro because then
people changing lockdep would see that they cannot rely on
lockdep_init_map() having been called (unless subclass != 0)

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (191 bytes)