linux-kernel - Re: [PATCH] Some love to default profiler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070710124343.GS11166@waste.org>
Date:	Tue, 10 Jul 2007 07:43:44 -0500
From:	Matt Mackall <mpm@...enic.com>
To:	Alexey Dobriyan <adobriyan@...il.com>
Cc:	akpm@...l.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Some love to default profiler

On Thu, Jul 05, 2007 at 01:34:20AM +0400, Alexey Dobriyan wrote:
> 1) Drop __KERNEL__ out of profile.h. It contains only internal kernel stuff and
>    not in exported headers list
> 2) Put profile.c under CONFIG_PROFILING. You enabled profiling in config, you
>    will get it. Removes conditional branch from schedule(). Code savings on my
>    usual config:
> 
> 	   text	   data	    bss	    dec	    hex	filename
> 	2921871	 179895	 180224	3281990	 321446	vmlinux		before
> 	2920141	 179847	 180224	3280212	 320d54	vmlinux		after
> 	--------------------------------------------------------------
> 	  -1730     -48           -1778
> 
> 3) Make timer_hook static (hi, Adrian!)
> 4) Convert do {} while (0) into static inline functions
> 5) minor misc stuff

Something here suggests this should have been 5 patches.

Otherwise, looks good to me.

-- 
Mathematics is the supreme nostalgia of our time.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/