linux-kernel - Always zero test in arch/i386/pci/mmconfig-shared.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <4693CE63.1090102@talk21.com>
Date:	Tue, 10 Jul 2007 19:22:27 +0100
From:	Scott Ashcroft <scott.ashcroft@...k21.com>
To:	Kernel development list <linux-kernel@...r.kernel.org>
Subject: Always zero test in arch/i386/pci/mmconfig-shared.c

I don't think it makes any change to subsequent flow but the code in 
pci_mmcfg_check_hostbridge is:

pci_mmcfg_config_num = 0;

...

if (name) {
	printk(KERN_INFO "PCI: Found %s %s MMCONFIG support.\n",
	       name, pci_mmcfg_config_num ? "with" : "without");
}

So it will always prints "without".

I'd make a patch but I'm not sure what this fix is. Just drop the test, 
the printk or make it say "which might possibly have"?

Cheers,
Scott
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/