lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4697FCBD.7050003@zytor.com>
Date:	Fri, 13 Jul 2007 15:29:17 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Gabriel C <nix.or.die@...glemail.com>
CC:	linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	trivial@...nel.org
Subject: Re: [PATCH] broken lilo check on make install

Gabriel C wrote:
> 
> I don't use and don't have lilo installed on this system. The attached
> patch fixes the problem for me.
> 

You also don't have a /sbin/installkernel, which is arguably a bug too.
 However, the patch mostly makes sense, although I would suggest putting
a "sync" in the else clause.

With that caveat, Acked-by: H. Peter Anvin <hpa@...or.com>

> Signed-off-by: Gabriel Craciunescu <nix.or.die@...glemail.com>
> 
> 
> diff --git a/arch/i386/boot/install.sh b/arch/i386/boot/install.sh
> index 5e44c73..7099fd6 100644
> --- a/arch/i386/boot/install.sh
> +++ b/arch/i386/boot/install.sh
> @@ -51,4 +51,10 @@ fi
>  cat $2 > $4/vmlinuz
>  cp $3 $4/System.map
>  
> -if [ -x /sbin/lilo ]; then /sbin/lilo; else /etc/lilo/install; fi
> +if [ -x /sbin/lilo ]; then
> +       /sbin/lilo
> +elif [ -x /etc/lilo/install ]; then
> +       /etc/lilo/install
> +else
> +       echo "Cannot find LILO."
> +fi
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ