linux-kernel - Re: Always zero test in arch/i386/pci/mmconfig-shared.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-id: <46980DE4.6090404@shaw.ca>
Date:	Fri, 13 Jul 2007 17:42:28 -0600
From:	Robert Hancock <hancockr@...w.ca>
To:	Scott Ashcroft <scott.ashcroft@...k21.com>
Cc:	Kernel development list <linux-kernel@...r.kernel.org>
Subject: Re: Always zero test in arch/i386/pci/mmconfig-shared.c

Scott Ashcroft wrote:
> I don't think it makes any change to subsequent flow but the code in 
> pci_mmcfg_check_hostbridge is:
> 
> pci_mmcfg_config_num = 0;
> 

You missed this code:

name = pci_mmcfg_probes[i].probe();

This calls one of the probe functions above, which will set 
pci_mmcfg_config_num to something else, as with the name variable. It 
may set the name but not the config num, if the chipset is recognized 
but MMCONFIG isn't enabled, etc.

> 
> if (name) {
>     printk(KERN_INFO "PCI: Found %s %s MMCONFIG support.\n",
>            name, pci_mmcfg_config_num ? "with" : "without");
> }
> 
> So it will always prints "without".
> 
> I'd make a patch but I'm not sure what this fix is. Just drop the test, 
> the printk or make it say "which might possibly have"?
> 
> Cheers,
> Scott

-- 
Robert Hancock      Saskatoon, SK, Canada
To email, remove "nospam" from hancockr@...pamshaw.ca
Home Page: http://www.roberthancock.com/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/