linux-kernel - Re: Always zero test in arch/i386/pci/mmconfig-shared.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4698164C.3080302@talk21.com>
Date:	Sat, 14 Jul 2007 01:18:20 +0100
From:	Scott Ashcroft <scott.ashcroft@...k21.com>
To:	Robert Hancock <hancockr@...w.ca>
CC:	Kernel development list <linux-kernel@...r.kernel.org>
Subject: Re: Always zero test in arch/i386/pci/mmconfig-shared.c

Robert Hancock wrote:
  > You missed this code:
> 
> name = pci_mmcfg_probes[i].probe();
> 
> This calls one of the probe functions above, which will set 
> pci_mmcfg_config_num to something else, as with the name variable. It 
> may set the name but not the config num, if the chipset is recognized 
> but MMCONFIG isn't enabled, etc.

Obvious now you've pointed it out. Bit of of a weird way to do things.
I might brew up a patch which adds the names to the 
pci_mmcfg_hostbridge_probe struct, since they appear to be always 
returned if the probe function is called, and make the probe functions 
return the config num.

Cheers,
Scott
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/