linux-kernel - Re: [PATCH] splice: fix wrong __splice_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87odiczkky.fsf@duaron.myhome.or.jp>
Date:	Mon, 16 Jul 2007 19:53:01 +0900
From:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To:	Jens Axboe <jens.axboe@...cle.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] splice: fix wrong __splice_from_pipe() usage

Jens Axboe <jens.axboe@...cle.com> writes:

> On Mon, Jul 16 2007, OGAWA Hirofumi wrote:
>> Hi,
>> 
>> I've noticed the nfsd read corruption by recent change. And this patch
>> fixes the problem for me, is this right fix?
>> -- 
>> OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
>> 
>> 
>> __splice_from_pipe() is updating the sd->pos for the actor, but those
>> functions are passing the sd of reader side directory. So, splice
>> updates sd->pos twice.
>> 
>> This fixes usage of __splice_from_pipe().
>
> For sendfile() usage, or the nfsd path that uses splice to send?

nfsd_vfs_read() path.

nfsd_vfs_read()
    splice_direct_to_actor()
        while(len) {
            do_splice_to()                     [update sd->pos]
                -> generic_file_splice_read()  [read from sd->pos]
            nfsd_direct_splice_actor()
                -> __splice_from_pipe()        [update sd->pos]
        }

do_splice_to() updates sd->pos for read, and pass updated sd to
__splice_from_pipe(), and __splice_from_pipe() updates sd->pos for
write. So, next do_splice_to() read from wrong position.
-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/