linux-kernel - Re: [PATCH] splice: fix wrong __splice_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070716063435.GG5328@kernel.dk>
Date:	Mon, 16 Jul 2007 08:34:36 +0200
From:	Jens Axboe <jens.axboe@...cle.com>
To:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] splice: fix wrong __splice_from_pipe() usage

On Mon, Jul 16 2007, OGAWA Hirofumi wrote:
> Hi,
> 
> I've noticed the nfsd read corruption by recent change. And this patch
> fixes the problem for me, is this right fix?
> -- 
> OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
> 
> 
> __splice_from_pipe() is updating the sd->pos for the actor, but those
> functions are passing the sd of reader side directory. So, splice
> updates sd->pos twice.
> 
> This fixes usage of __splice_from_pipe().

For sendfile() usage, or the nfsd path that uses splice to send?

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/