linux-kernel - Re: maps2-move-the-page-walker-code-to-lib.patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1184634597.5955.42.camel@localhost.localdomain>
Date:	Tue, 17 Jul 2007 11:09:57 +1000
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Sam Ravnborg <sam@...nborg.org>
Cc:	Matt Mackall <mpm@...enic.com>,
	Jeremy Fitzhardinge <jeremy@...p.org>,
	David Rientjes <rientjes@...gle.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	lkml - Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: maps2-move-the-page-walker-code-to-lib.patch

On Fri, 2007-07-13 at 22:48 +0200, Sam Ravnborg wrote:
> On Tue, Jul 10, 2007 at 12:06:35PM +1000, Rusty Russell wrote:
> > On Mon, 2007-07-09 at 15:22 -0500, Matt Mackall wrote:
> > > On Sun, Jul 08, 2007 at 03:49:56PM +1000, Rusty Russell wrote:
> > > > Matt wrote:
> > > > > This lets it get shared outside of proc/ and linked in only when needed.
> > > > 
> > > > Erk, this really belongs in the mm dir.  You can use "lib-y +=
> > > > pagewalk.o" there, and it seems to work as well as doing it in lib.
> > > 
> > > Are you sure? I tested that a few months ago and it didn't work for
> > > me. I seem to recall it wanted a chunk of makefile surgery.
> > 
> > Well, I tested here and it worked unless I screwed something (producing
> > lib.a in mm/ and linking it in).  And when I turned off all the CONFIG
> > options which required it, the symbols disappeared from the vmlinux...
> 
> I think you had some additional change somewhere...
> kbuild will only look for lib.a files (produced from all files
> listed with lib-y _except_ files listed with obj-y too).

You're right: mm/lib.a gets built, but not linked in.  Sorry for the
false report...

Rusty.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/