linux-kernel - Re: [PATCH] appletouch powersaving

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d120d5000707170801u27e11936h9546bd36da7a1162@mail.gmail.com>
Date:	Tue, 17 Jul 2007 11:01:48 -0400
From:	"Dmitry Torokhov" <dmitry.torokhov@...il.com>
To:	"Soeren Sonnenburg" <kernel@....de>
Cc:	"Linux Kernel" <linux-kernel@...r.kernel.org>,
	linux-input@...ey.karlin.mff.cuni.cz,
	linux-usb-devel@...ts.sourceforge.net,
	"Matthew Garrett" <mjg59@...f.ucam.org>,
	"Nicolas Boichat" <nicolas@...chat.ch>,
	"Michael Hanselmann" <linux-kernel@...smi.ch>,
	"Peter Osterlund" <petero2@...ia.com>,
	"Frank Arnold" <frank@...rocco-5v-turbo.de>,
	"Stelian Pop" <stelian@...ies.net>,
	"Johannes Berg" <johannes@...solutions.net>,
	"Greg Kroah-Hartman" <greg@...ah.com>
Subject: Re: [PATCH] appletouch powersaving - please apply for 2.6.23-rc1

Hi,

On 7/17/07, Soeren Sonnenburg <kernel@....de> wrote:
>
>  err_free_buffer:
> @@ -656,6 +699,7 @@ static void atp_disconnect(struct usb_interface *iface)
>
>        usb_set_intfdata(iface, NULL);
>        if (dev) {
> +               cancel_work_sync(&dev->work);
>                usb_kill_urb(dev->urb);
>                input_unregister_device(dev->input);
>                usb_buffer_free(dev->udev, dev->datalen,
>

This should go into atp_close() and I think you need to do
cancel_work_sync after calling usb_kill_urb() otherwise you risk it
being submitted while you gettingto kill the urb.

How many boxes did you try this patch on?

-- 
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/