linux-kernel - Re: [PATCH] smp_call_function_single() should be a macro on UP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070717.144042.41636155.davem@davemloft.net>
Date:	Tue, 17 Jul 2007 14:40:42 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	viro@....linux.org.uk
Cc:	torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org,
	avi@...ranet.com
Subject: Re: [PATCH] smp_call_function_single() should be a macro on UP

From: Al Viro <viro@....linux.org.uk>
Date: Tue, 17 Jul 2007 22:29:46 +0100

> ... or we end up with header include order problems from hell.
> E.g. on m68k this is 100% fatal - local_irq_enable() there
> wants preempt_count(), which wants task_struct fields, which
> we won't have when we are in smp.h pulled from sched.h.
> 
> Signed-off-by: Al Viro <viro@...iv.linux.org.uk>

Acked-by: David S. Miller <davem@...emloft.net>

I was going to fix the sparc64/UP build fallout by
adding linux/kernel.h include to linux/smp.h but that
definitely would not handle this m68k case at all.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/