linux-kernel - Re: [PATCH] appletouch powersaving

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070718155758.072db90d.akpm@linux-foundation.org>
Date:	Wed, 18 Jul 2007 15:57:58 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Soeren Sonnenburg <kernel@....de>
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>,
	linux-input@...ey.karlin.mff.cuni.cz,
	linux-usb-devel@...ts.sourceforge.net,
	Matthew Garrett <mjg59@...f.ucam.org>,
	Nicolas Boichat <nicolas@...chat.ch>,
	Michael Hanselmann <linux-kernel@...smi.ch>,
	Peter Osterlund <petero2@...ia.com>,
	Frank Arnold <frank@...rocco-5v-turbo.de>,
	Stelian Pop <stelian@...ies.net>,
	Johannes Berg <johannes@...solutions.net>,
	Greg Kroah-Hartman <greg@...ah.com>
Subject: Re: [PATCH] appletouch powersaving - please apply for 2.6.23-rc1

On Tue, 17 Jul 2007 09:10:18 +0200
Soeren Sonnenburg <kernel@....de> wrote:

> the attached minimally intrusive patch is based on Matthew Garret's
> patch 'Make appletouch shut up when it has nothing to say' patches (e.g.
> http://lkml.org/lkml/2007/5/13/117): Matthews description follows /
> second paragraph lists my additional changes.
> 
> The appletouch geyser3 devices found in the Intel Macs (and possibly some later 
> PPC ones?) send a constant stream of packets after the first touch. This 
> results in the kernel waking up around once every couple of milliseconds 
> to process them, making it almost impossible to spend any significant 
> period of time in C3 state on a dynamic HZ kernel. Sending the mode 
> initialization code makes the device shut up until it's touched again. 
> This patch does so after receiving 10 packets with no interesting 
> content.
> 
> In addition it now empties the work queue via cancel_work_sync on module
> exit, keeps all error checking and only reports BTN_LEFT presses if bit
> 1 in the status byte (last byte in packet) is set. This fixes the random
> left clicks issue. Furthermore it invalidates touchpad data before the
> mode switch, which fixes the touchpad runs amok issue.

Please feed this through scripts/checkpatch.pl and consider addressing
all the things which it reports.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/