linux-kernel - Re: [PATCH] appletouch powersaving - please apply for 2.6.23-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1184816154.6161.187.camel@localhost>
Date:	Thu, 19 Jul 2007 03:35:54 +0000
From:	Soeren Sonnenburg <kernel@....de>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>,
	linux-input@...ey.karlin.mff.cuni.cz,
	linux-usb-devel@...ts.sourceforge.net,
	Matthew Garrett <mjg59@...f.ucam.org>,
	Nicolas Boichat <nicolas@...chat.ch>,
	Michael Hanselmann <linux-kernel@...smi.ch>,
	Peter Osterlund <petero2@...ia.com>,
	Frank Arnold <frank@...rocco-5v-turbo.de>,
	Stelian Pop <stelian@...ies.net>,
	Johannes Berg <johannes@...solutions.net>,
	Greg Kroah-Hartman <greg@...ah.com>
Subject: Re: [PATCH] appletouch powersaving - please apply for 2.6.23-rc1 -
	take #4

On Wed, 2007-07-18 at 15:57 -0700, Andrew Morton wrote:
> On Tue, 17 Jul 2007 09:10:18 +0200
> Soeren Sonnenburg <kernel@....de> wrote:
> 
> > the attached minimally intrusive patch is based on Matthew Garret's
> > patch 'Make appletouch shut up when it has nothing to say' patches (e.g.
> > http://lkml.org/lkml/2007/5/13/117): Matthews description follows /
> > second paragraph lists my additional changes.
> > 
> > The appletouch geyser3 devices found in the Intel Macs (and possibly some later 
> > PPC ones?) send a constant stream of packets after the first touch. This 
> > results in the kernel waking up around once every couple of milliseconds 
> > to process them, making it almost impossible to spend any significant 
> > period of time in C3 state on a dynamic HZ kernel. Sending the mode 
> > initialization code makes the device shut up until it's touched again. 
> > This patch does so after receiving 10 packets with no interesting 
> > content.
> > 
> > In addition it now empties the work queue via cancel_work_sync on module
> > exit, keeps all error checking and only reports BTN_LEFT presses if bit
> > 1 in the status byte (last byte in packet) is set. This fixes the random
> > left clicks issue. Furthermore it invalidates touchpad data before the
> > mode switch, which fixes the touchpad runs amok issue.
> 
> Please feed this through scripts/checkpatch.pl and consider addressing
> all the things which it reports.

So I did. Updated patch which differs in

dev->valid = 0; (note the space around =) and further removed debug code
(which never got triggered but checkpatch.pl complained about)
                                                                                                                                          
attached.

Soeren
-- 
Sometimes, there's a moment as you're waking, when you become aware of
the real world around you, but you're still dreaming.

View attachment "appletouch4.patch" of type "text/x-patch" (6586 bytes)