linux-kernel - Re: [PATCH 4/8] eCryptfs: Fix Tag 1 parsing code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070719215347.GA14091@halcrow.austin.ibm.com>
Date:	Thu, 19 Jul 2007 16:53:48 -0500
From:	Michael Halcrow <mhalcrow@...ibm.com>
To:	Josef Sipek <jsipek@....cs.sunysb.edu>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	tchicks@...ibm.com, trevor.highland@...il.com,
	pregan@...sunysb.edu, toml@...ibm.com, sergeh@...ibm.com,
	mike@...crow.us
Subject: Re: [PATCH 4/8] eCryptfs: Fix Tag 1 parsing code

On Thu, Jul 19, 2007 at 05:41:16PM -0400, Josef Sipek wrote:
> On Thu, Jul 19, 2007 at 04:28:01PM -0500, Michael Halcrow wrote:
> > Fix up the Tag 1 parsing code to handle size limits and boundaries
> > more explicitly. Initialize the new auth_tok's flags.
> ...
> > -	if (unlikely((*packet_size) + 3 > max_packet_size)) {
> > -		ecryptfs_printk(KERN_ERR, "Packet size exceeds max\n");
> > +	if (unlikely(max_packet_size < 12)) {
> > +		printk(KERN_ERR "Invalid max packet size; must be >=12\n");
> 
> Hardcoded 12?

It's not so much a magic number if you preserve the comment
immediately above it.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/