linux-kernel - RE: build fix for x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 19 Jul 2007 16:54:51 -0700
From:	"Luck, Tony" <tony.luck@...el.com>
To:	"Andi Kleen" <ak@...e.de>, "Arthur Jones" <arthur.jones@...gic.com>
Cc:	"Vasily Tarasov" <vtaras@...nvz.org>,
	<linux-kernel@...r.kernel.org>, "Jan Kara" <jack@....cz>,
	<linux-arch@...r.kernel.org>
Subject: RE: build fix for x86_64...

> Looks good.

Looks good to me too (I'm to blame for the version posted by Doug
that only fixed ia64 ... I didn't take the time to check whether
there was a CONFIG_COMPAT option for x86_64 ... oops).

> Tony, perhaps it would make sense to define some common CONFIG
> for COMPAT_FOR_U64_ALIGNMENT longer term to make the #ifs for this
> case a little less ugly.

Certainly if there is ever a third architecture that needs this the
#if mess will be beyond bad.  But with only the two of us we'd trade
one ugly #ifdef line here for another half-dozen lines in each of
our Kconfig files to define the new term.  I'm not sure whether that
is a win.

-Tony
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/