linux-kernel - Re: [PATCH] fs/fuse/dev.c: use zero_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a8e1da0707200316y68fdbb39o8b21d3ebdefa5c05@mail.gmail.com>
Date:	Fri, 20 Jul 2007 10:16:05 +0000
From:	"Dave Young" <hidave.darkstar@...il.com>
To:	"rae l" <crquan@...il.com>
Cc:	"Miklos Szeredi" <miklos@...redi.hu>,
	fuse-devel@...ts.sourceforge.net, viro@...iv.linux.org.uk,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs/fuse/dev.c: use zero_user_page instead

>On 7/20/07, rae l <crquan@...il.com> wrote:
> On 7/20/07, Dave Young <hidave.darkstar@...il.com> wrote:
> > > -       if (page && zeroing && count < PAGE_SIZE) {
> > > -               void *mapaddr = kmap_atomic(page, KM_USER1);
> > > -               memset(mapaddr, 0, PAGE_SIZE);
> > > -               kunmap_atomic(mapaddr, KM_USER1);
> > > -       }
> > > +       if (page && zeroing && count < PAGE_SIZE)
> > > +               zero_user_page(page, 0, PAGE_SIZE, KM_USER1);
> > Why clear all page? IMHO,only count bytes need to be cleared.
> The original one is memset(mapaddr, 0, PAGE_SIZE), namely clear the whole page.
Yes, I have same suspicion with original code.
>
> --
> Denis Cheng
> Linux Application Developer
>
> "One of my most productive days was throwing away 1000 lines of code."
>  - Ken Thompson.
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/