linux-kernel - Re: [PATCH][resend] Remove spec doc links in hpet header files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 20 Jul 2007 01:37:16 +0000
From:	"Dave Young" <hidave.darkstar@...il.com>
To:	"Andrew Morton" <akpm@...ux-foundation.org>
Cc:	randy.dunlap@...cle.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][resend] Remove spec doc links in hpet header files

>On 7/20/07, Andrew Morton <akpm@...ux-foundation.org> wrote:
> On Fri, 20 Jul 2007 08:45:10 +0000
> Dave Young <hidave.darkstar@...il.com> wrote:
>
> > Hi,
> > The links are broken, and already exist in Documentation/hpet.txt, so
> > remove them for header files.
> >
> > Signed-off-by: Dave Young <hidave.darkstar@...il.com>
> > Acked-by: Randy Dunlap <randy.dunlap@...cle.com>
> >
> > ---
> > include/asm-i386/hpet.h   |    6 ------
> > include/asm-x86_64/hpet.h |    6 ------
> > 2 files changed, 12 deletions(-)
> >
> > diff -pur linux/include/asm-i386/hpet.h linux.new/include/asm-i386/hpet.h
> > --- linux/include/asm-i386/hpet.h     2007-07-11 11:15:42.000000000 +0000
> > +++ linux.new/include/asm-i386/hpet.h 2007-07-11 11:16:51.000000000 +0000
> > @@ -28,12 +28,6 @@
> >
> >  #include <linux/timex.h>
> >
> > -/*
> > - * Documentation on HPET can be found at:
> > - *      http://www.intel.com/ial/home/sp/pcmmspec.htm
> > - *      ftp://download.intel.com/ial/home/sp/mmts098.pdf
> > - */
> > -
> >  #define HPET_MMAP_SIZE       1024
> >
> >  #define HPET_ID              0x000
> > diff -pur linux/include/asm-x86_64/hpet.h linux.new/include/asm-x86_64/hpet.h
> > --- linux/include/asm-x86_64/hpet.h   2007-07-11 11:16:07.000000000 +0000
> > +++ linux.new/include/asm-x86_64/hpet.h       2007-07-11 11:17:03.000000000 +0000
> > @@ -1,12 +1,6 @@
> >  #ifndef _ASM_X8664_HPET_H
> >  #define _ASM_X8664_HPET_H 1
> >
> > -/*
> > - * Documentation on HPET can be found at:
> > - *      http://www.intel.com/ial/home/sp/pcmmspec.htm
> > - *      ftp://download.intel.com/ial/home/sp/mmts098.pdf
> > - */
> > -
> >  #define HPET_MMAP_SIZE       1024
> >
> >  #define HPET_ID              0x000
>
> It only half-applies here because 100 monkeys are tromping all over the
> hpet code.
>
> But I'm inclined to duck it anyway: having the documentation references in
> the soruce doesn't hurt, and nobody looks in Documentation/.
>

Hi,
But at least the web urls are broken, please update to below address:
<http://www.intel.com/technology/architecture/hpetspec.htm>.

Regards
dave
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/