linux-kernel - Re: i386: pata_cs5520 does not work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <46A00E41.5090608@novell.com>
Date:	Fri, 20 Jul 2007 10:22:09 +0900
From:	Tejun Heo <teheo@...ell.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
CC:	TAKADA Yoshihito <takada@....nifty.com>,
	linux-kernel@...r.kernel.org
Subject: Re: i386: pata_cs5520 does not work

Alan Cox wrote:
> O> > rc = devm_request_irq(&pdev->dev, irq[ap->port_no],
>>> 	ata_interrupt, 0, DRV_NAME, host);
>> devm_request_irq() is called twice from loop.
>> In 1st time, ap->port_no is 0. devm_request_irq() is success.
>> 2nd time, ap->port_no is 0 too. devm_request_irq() failed.
> 
> Looks like whoever updated it to the new probe mechanism didn't quite get
> it right
> 
> Change it to use 
> 
>           struct ata_port *ap = host->ports[i];
> 
> not ports[0]

Eh.... That was me being stupid.  Sorry about that.

-- 
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/